Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: rm /intg/test_ssh_pubkey.py #7608

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tests: rm /intg/test_ssh_pubkey.py #7608

wants to merge 1 commit into from
+74 −342

Conversation

danlavu
Copy link

@danlavu danlavu commented Sep 19, 2024

  • multihost/ipa/test_misc.py functionally covers this scenario
  • test_ssh_sighup offers minimal value and should be dropped now

@danlavu danlavu changed the title tests: rm intg ssh_pubkey tests: rm /intg/test_ssh_pubkey.py Sep 19, 2024
madhuriupadhye
madhuriupadhye previously approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@madhuriupadhye madhuriupadhye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexey-tikhonov
Copy link
Member

Multihosts tests aren't run in upstream PR CI

@danlavu danlavu marked this pull request as draft October 3, 2024 05:22
@danlavu
Copy link
Author

danlavu commented Oct 3, 2024

ACK, I extended the framework to provide user SSH key functionality. I need to test it, and I can then write a quick test to cover this.

@danlavu danlavu dismissed madhuriupadhye’s stale review October 3, 2024 05:24

This PR is changing.

@danlavu
Copy link
Author

danlavu commented Oct 7, 2024

depends on SSSD/sssd-test-framework#131 , tests are going to fail.

@danlavu danlavu mentioned this pull request Oct 7, 2024
Merged
@danlavu
Copy link
Author

danlavu commented Oct 7, 2024

Though... sss_ssh_authorizedkeys is no longer providing output. Need to figure out why.

@danlavu danlavu force-pushed the tests-rm-intg-ssh_pubkey branch 2 times, most recently from 2033e67 to 9907312 Compare October 8, 2024 03:38
@danlavu danlavu force-pushed the tests-rm-intg-ssh_pubkey branch 3 times, most recently from 1e3e7c9 to c2070e1 Compare October 16, 2024 12:57
@danlavu danlavu force-pushed the tests-rm-intg-ssh_pubkey branch 2 times, most recently from 7745a1d to eda1acb Compare November 5, 2024 02:54
tests: rm intg ssh_pubkey
52e7a05 
* multihost/ipa/test_misc.py functionally covers this scenario
@danlavu danlavu marked this pull request as ready for review November 5, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madhuriupadhye madhuriupadhye madhuriupadhye left review comments

Assignees

@madhuriupadhye madhuriupadhye

Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danlavu @alexey-tikhonov @madhuriupadhye